| From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Always call ExecShutdownNode() if appropriate. |
| Date: | 2019-11-15 21:30:30 |
| Message-ID: | E1iVjAk-0001Xi-CX@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Always call ExecShutdownNode() if appropriate.
Call ExecShutdownNode() after ExecutePlan()'s loop, rather than at each
break. We had forgotten to do that in one case. The omission caused
intermittent "temporary file leak" warnings from multi-batch parallel
hash joins with a LIMIT clause.
Back-patch to 11. Though the problem exists in theory in earlier
parallel query releases, nothing really depended on it.
Author: Kyotaro Horiguchi
Reviewed-by: Thomas Munro, Amit Kapila
Discussion: https://postgr.es/m/20191111.212418.2222262873417235945.horikyota.ntt%40gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/76cbfcdf3a0dff3f029ca079701418b861ce86c8
Modified Files
--------------
src/backend/executor/execMain.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-11-15 21:30:46 | pgsql: Always call ExecShutdownNode() if appropriate. |
| Previous Message | Tom Lane | 2019-11-15 17:32:00 | pgsql: Doc: in v12 release notes, explain how to replace uses of consrc |