pgsql: Handle arrays and ranges in pg_upgrade's test for non-upgradable

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Handle arrays and ranges in pg_upgrade's test for non-upgradable
Date: 2019-11-13 16:36:05
Message-ID: E1iUvcj-0002Z3-0c@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Handle arrays and ranges in pg_upgrade's test for non-upgradable types.

pg_upgrade needs to check whether certain non-upgradable data types
appear anywhere on-disk in the source cluster. It knew that it has
to check for these types being contained inside domains and composite
types; but it somehow overlooked that they could be contained in
arrays and ranges, too. Extend the existing recursive-containment
query to handle those cases.

We probably should have noticed this oversight while working on
commit 0ccfc2822 and follow-ups, but we failed to :-(. The whole
thing's possibly a bit overdesigned, since we don't really expect
that any of these types will appear on disk; but if we're going to
the effort of doing a recursive search then it's silly not to cover
all the possibilities.

While at it, refactor so that we have only one copy of the search
logic, not three-and-counting. Also, to keep the branches looking
more alike, back-patch the output wording change of commit 1634d3615.

Back-patch to all supported branches.

Discussion: https://postgr.es/m/31473.1573412838@sss.pgh.pa.us

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c443e3c439273217d1e9a6e1a933ece302aa4ba1

Modified Files
--------------
src/bin/pg_upgrade/version.c | 245 +++++++++++++++++--------------------------
1 file changed, 99 insertions(+), 146 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-11-13 17:12:01 pgsql: Include TableFunc references when computing expression dependenc
Previous Message Tom Lane 2019-11-13 16:36:04 pgsql: Handle arrays and ranges in pg_upgrade's test for non-upgradable