pgsql: Fix thinkos from 4f4061b for libpq integer parsing

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix thinkos from 4f4061b for libpq integer parsing
Date: 2019-10-23 02:35:54
Message-ID: E1iN6V8-0004F7-5J@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix thinkos from 4f4061b for libpq integer parsing

A check was redundant. While on it, add an assertion to make sure that
the parsing routine is never called with a NULL input. All the code
paths currently calling the parsing routine are careful with NULL inputs
already, but future callers may forget that.

Reported-by: Peter Eisentraut, Lars Kanis
Discussion: https://postgr.es/m/ec64956b-4597-56b6-c3db-457d15250fe4@2ndquadrant.com
Backpatch-through: 12

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/57379cd5ac56e575630a5fee5777a1035d0a764a

Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-10-23 02:37:05 Re: pgsql: Fix parsing of integer values for connection parameters in libpq
Previous Message Michael Paquier 2019-10-23 01:27:42 pgsql: Clean up properly error_context_stack in autovacuum worker on ex