pgsql: Fix bogus order of error checks in new channel_binding code.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix bogus order of error checks in new channel_binding code.
Date: 2019-09-29 16:35:58
Message-ID: E1iEcAx-0002Oa-00@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus order of error checks in new channel_binding code.

Coverity pointed out that it's pretty silly to check for a null pointer
after we've already dereferenced the pointer. To fix, just swap the
order of the two error checks. Oversight in commit d6e612f83.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2c97f73468419672f2340afb24f1321695ee3002

Modified Files
--------------
src/interfaces/libpq/fe-auth.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-09-29 16:51:31 Re: pgsql: Add libpq parameter 'channel_binding'.
Previous Message Alexander Korotkov 2019-09-29 14:29:56 Re: pgsql: Implement jsonpath .datetime() method