pgsql: Fix some minor spec-compliance issues in jsonpath lexer.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix some minor spec-compliance issues in jsonpath lexer.
Date: 2019-09-20 18:23:06
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Fix some minor spec-compliance issues in jsonpath lexer.

Although the SQL/JSON tech report makes reference to ECMAScript which
allows both single- and double-quoted strings, all the rest of the
report speaks only of double-quoted string literals in jsonpaths.
That's more compatible with JSON itself; moreover single-quoted strings
are hard to use inside a jsonpath that is itself a single-quoted SQL
literal. So guess that the intent is to allow only double-quoted
literals, and remove lexer support for single-quoted literals.
It'll be less painful to add this again later if we're wrong, than to
remove a shipped feature.

Also, adjust the lexer so that unrecognized backslash sequences are
treated as just meaning the escaped character, not as errors. This
change has much better support in the standards, as JSON, JavaScript
and ECMAScript all make it plain that that's what's supposed to

Back-patch to v12.




Modified Files
src/backend/utils/adt/jsonpath_scan.l | 79 +++++++++--------------
src/test/regress/expected/jsonpath.out | 18 ++----
src/test/regress/expected/jsonpath_encoding.out | 78 ----------------------
src/test/regress/expected/jsonpath_encoding_1.out | 72 ---------------------
src/test/regress/sql/jsonpath.sql | 3 +-
src/test/regress/sql/jsonpath_encoding.sql | 23 -------
6 files changed, 38 insertions(+), 235 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-09-20 22:37:20 pgsql: Optimize get_jsonb_path_all avoiding an iterator
Previous Message Tom Lane 2019-09-20 16:47:54 pgsql: Revert "Add DECLARE STATEMENT support to ECPG."