pgsql: Fix intermittent self-test failures caused by the stats_ext test

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix intermittent self-test failures caused by the stats_ext test
Date: 2019-09-15 12:23:06
Message-ID: E1i9TYY-0004ba-W5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix intermittent self-test failures caused by the stats_ext test.

Commit d7f8d26d9 added new tests to the stats_ext regression test that
included creating a view in the public schema, without realising that
the stats_ext test runs in the same parallel group as the rules test,
which makes doing that unsafe.

This led to intermittent failures of the rules test on the buildfarm,
although I wasn't able to reproduce that locally. Fix by creating the
view in a different schema.

Tomas Vondra and Dean Rasheed, report and diagnosis by Thomas Munro.

Discussion: https://postgr.es/m/CA+hUKGKX9hFZrYA7rQzAMRE07L4hziCc-nO_b3taJpiuKyLLxg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3d9a3ef5cbfc70bd2802c3f0da3fbc4e5abdf377

Modified Files
--------------
src/test/regress/expected/stats_ext.out | 42 ++++++++++++++++++---------------
src/test/regress/sql/stats_ext.sql | 40 ++++++++++++++++---------------
2 files changed, 44 insertions(+), 38 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-09-15 15:52:06 pgsql: Fix bogus sizeof calculations.
Previous Message Noah Misch 2019-09-15 02:48:29 pgsql: Revert "For all ppc compilers, implement pg_atomic_fetch_add_ wi