| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro |
| Date: | 2019-09-08 21:01:20 |
| Message-ID: | E1i74JE-00024X-9j@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix RelationIdGetRelation calls that weren't bothering with error checks.
Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.
While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test. The machine code is the same
but it seems better to be consistent.
Coverity complained about this today, not sure why, because the
mistake is in fact old.
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/deba7c6fc3ccbaadfccbf70f73480d33a27b15b4
Modified Files
--------------
src/backend/access/heap/heapam.c | 4 ++++
src/backend/replication/logical/reorderbuffer.c | 6 +++++-
2 files changed, 9 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2019-09-08 21:54:12 | Re: pgsql: Use data directory inode number, not port, to select SysV resour |
| Previous Message | Alexander Korotkov | 2019-09-08 19:31:12 | pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator |