From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix behavior of AND CHAIN outside of explicit transaction blocks |
Date: | 2019-09-08 14:34:49 |
Message-ID: | E1i6yHB-0000ib-Dj@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix behavior of AND CHAIN outside of explicit transaction blocks
When using COMMIT AND CHAIN or ROLLBACK AND CHAIN not in an explicit
transaction block, the previous implementation would leave a
transaction block active in the ROLLBACK case but not the COMMIT case.
To fix for now, error out when using these commands not in an explicit
transaction block. This restriction could be lifted if a sensible
definition and implementation is found.
Bug: #15977
Author: fn ln <emuser20140816(at)gmail(dot)com>
Reviewed-by: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/862ef372d6b23629f93d4afc123ddd7d172501ac
Modified Files
--------------
doc/src/sgml/ref/commit.sgml | 3 +-
doc/src/sgml/ref/rollback.sgml | 3 +-
src/backend/access/transam/xact.c | 58 +++++++++++++++-------
src/test/regress/expected/transactions.out | 78 ++++++++++++++++++++++++++++++
src/test/regress/sql/transactions.sql | 43 ++++++++++++++++
5 files changed, 166 insertions(+), 19 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-09-08 17:45:48 | pgsql: configure: Update python search order |
Previous Message | Peter Eisentraut | 2019-09-08 09:37:49 | pgsql: doc: effective -> efficient |