| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix failure of --jobs with vacuumdb on Windows |
| Date: | 2019-08-27 00:15:45 |
| Message-ID: | E1i2P9F-0005Yn-H4@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix failure of --jobs with vacuumdb on Windows
FD_SETSIZE needs to be declared before winsock2.h, or it is possible to
run into buffer overflow issues when using --jobs. This is similar to
pgbench's solution done in a23c641.
This has been introduced by 71d84ef, and older versions have been using
the default value of FD_SETSIZE, defined at 64.
Per buildfarm member jacana, but this impacts all Windows animals
running the TAP tests. I have reproduced the failure locally to check
the patch.
Author: Michael Paquier
Reviewed-by: Andrew Dunstan
Discussion: https://postgr.es/m/20190826054000.GE7005@paquier.xyz
Backpatch-through: 9.5
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b783a38d4580d807210e26c2c09eb77b66d7286f
Modified Files
--------------
src/bin/scripts/vacuumdb.c | 4 ++++
1 file changed, 4 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-08-27 00:18:27 | Re: pgsql: Fix error handling of vacuumdb and reindexdb when running out of |
| Previous Message | Tom Lane | 2019-08-26 21:03:08 | pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET. |