pgsql: Refactor logic to remove trailing CR/LF characters from strings

Refactor logic to remove trailing CR/LF characters from strings

b654714 has reworked the way trailing CR/LF characters are removed from
strings. This commit introduces a new routine in common/string.c and
refactors the code so as the logic is in a single place, mostly.

Author: Michael Paquier
Reviewed-by: Bruce Momjian
Discussion: https://postgr.es/m/20190801031820.GF29334@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b8f2da0ac5a24f669c8d320c58646759b8fc69a5

Modified Files
--------------
src/backend/libpq/be-secure-common.c | 8 +++-----
src/bin/pg_ctl/pg_ctl.c | 10 +++-------
src/bin/pg_resetwal/pg_resetwal.c | 10 +++-------
src/bin/pg_upgrade/option.c | 20 +++++---------------
src/bin/psql/prompt.c | 10 +++++-----
src/common/string.c | 22 ++++++++++++++++++++++
src/include/common/string.h | 1 +
src/interfaces/libpq/fe-connect.c | 9 +++------
8 files changed, 45 insertions(+), 45 deletions(-)