| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix handling of "undef" in contrib/jsonb_plperl. |
| Date: | 2019-08-04 18:05:54 |
| Message-ID: | E1huKtG-0006BN-DR@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix handling of "undef" in contrib/jsonb_plperl.
Perl has multiple internal representations of "undef", and just
testing for SvTYPE(x) == SVt_NULL doesn't recognize all of them,
leading to "cannot transform this Perl type to jsonb" errors.
Use the approved test SvOK() instead.
Report and patch by Ivan Panchenko. Back-patch to v11 where
this module was added.
Discussion: https://postgr.es/m/1564783533.324795401@f193.i.mail.ru
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/df521ab79547b82471126e54e9dc7fead4a5a4fb
Modified Files
--------------
contrib/jsonb_plperl/expected/jsonb_plperl.out | 22 +++++++++++++++++++++-
contrib/jsonb_plperl/expected/jsonb_plperlu.out | 22 +++++++++++++++++++++-
contrib/jsonb_plperl/jsonb_plperl.c | 10 +++++-----
contrib/jsonb_plperl/sql/jsonb_plperl.sql | 13 +++++++++++++
contrib/jsonb_plperl/sql/jsonb_plperlu.sql | 13 +++++++++++++
5 files changed, 73 insertions(+), 7 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-08-04 19:00:53 | Re: pgsql: Improve pruning of a default partition |
| Previous Message | Tom Lane | 2019-08-04 17:07:28 | pgsql: Avoid picking already-bound TCP ports in kerberos and ldap test |