pgsql: Remove surplus call to table_finish_bulk_insert

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove surplus call to table_finish_bulk_insert
Date: 2019-07-01 15:17:32
Message-ID: E1hhy3g-0002Ds-Nl@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove surplus call to table_finish_bulk_insert

4de60244e added the call to table_finish_bulk_insert to the
CopyMultiInsertBufferCleanup function. We use a CopyMultiInsertBuffer even
for non-partitioned tables, so having the cleanup do that meant we would
call table_finsh_bulk_insert twice when performing COPY FROM with
a non-partitioned table.

Here we can just remove the direct call in CopyFrom and let
CopyMultiInsertBufferCleanup handle the call instead.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b2d69806d8cc902802a7b56ba37fb7c55e58b0ed

Modified Files
--------------
src/backend/commands/copy.c | 2 --
1 file changed, 2 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-07-01 15:33:35 Re: pgsql: Remove surplus call to table_finish_bulk_insert
Previous Message David Rowley 2019-07-01 14:06:59 Re: pgsql: Fix missing call to table_finish_bulk_insert during COPY