pgsql: Revert "Avoid spurious deadlocks when upgrading a tuple lock"

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert "Avoid spurious deadlocks when upgrading a tuple lock"
Date: 2019-06-17 02:24:51
Message-ID: E1hchKF-0000vw-Bq@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "Avoid spurious deadlocks when upgrading a tuple lock"

This reverts commits 3da73d6839dc and de87a084c0a5.

This code has some tricky corner cases that I'm not sure are correct and
not properly tested anyway, so I'm reverting the whole thing for next
week's releases (reintroducing the deadlock bug that we set to fix).
I'll try again afterwards.

Discussion: https://postgr.es/m/E1hbXKQ-0003g1-0C@gemulon.postgresql.org

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/03964e58efb8cbb8ecf3f4cdd27c8c757c30e89e

Modified Files
--------------
src/backend/access/heap/README.tuplock | 10 --
src/backend/access/heap/heapam.c | 83 +++---------
.../expected/tuplelock-upgrade-no-deadlock.out | 150 ---------------------
src/test/isolation/isolation_schedule | 1 -
.../specs/tuplelock-upgrade-no-deadlock.spec | 57 --------
5 files changed, 21 insertions(+), 280 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-06-17 02:25:55 Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock
Previous Message Michael Paquier 2019-06-17 01:32:11 Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock