pgsql: Fix confusing NOTICE text in REINDEX CONCURRENTLY

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix confusing NOTICE text in REINDEX CONCURRENTLY
Date: 2019-06-05 09:06:14
Message-ID: E1hYRs6-0001IP-Uk@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix confusing NOTICE text in REINDEX CONCURRENTLY

When performing REINDEX TABLE CONCURRENTLY, if all of the table's indexes
could not be reindexed, a NOTICE message claimed that the table had no
indexes. This was confusing, so let's change the NOTICE text to something
less confusing.

In passing, also mention in the comment before ReindexRelationConcurrently
that materialized views are supported too and also explain what the return
value of the function means.

Author: Ashwin Agrawal
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CALfoeithHvi13p_VyR8kt9o6Pa7Z=Smi6Nfc2anHnQx5Lj8bTQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e24a815c1c8550fcba5cc5aeb0d130db46570872

Modified Files
--------------
src/backend/commands/indexcmds.c | 35 +++++++++++++++++++++---------
src/test/regress/expected/create_index.out | 10 ++++-----
2 files changed, 30 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2019-06-05 20:11:04 pgsql: doc: Add links to tables
Previous Message Christoph Berg 2019-06-05 08:47:35 Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)