pgsql: postgres_fdw: Fix cost estimation for aggregate pushdown.

From: Etsuro Fujita <efujita(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: postgres_fdw: Fix cost estimation for aggregate pushdown.
Date: 2019-05-09 09:42:22
Message-ID: E1hOfZG-0004td-54@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Fix cost estimation for aggregate pushdown.

In commit 7012b132d0, which added support for aggregate pushdown in
postgres_fdw, the expense of evaluating the final scan/join target
computed by make_group_input_target() was not accounted for at all in
costing aggregate pushdown paths with local statistics. The right fix
for this would be to have a separate upper stage to adjust the final
scan/join relation (see comments for apply_scanjoin_target_to_paths());
but for now, fix by adding the tlist eval cost when costing aggregate
pushdown paths with local statistics.

Apply this to HEAD only to avoid destabilizing existing plan choices.

Author: Etsuro Fujita
Reviewed-By: Antonin Houska
Discussion: https://postgr.es/m/5C66A056.60007%40lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/edbcbe277d795ecc339b0e4fa29bae42ce1a7be9

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 16 +++++++++++++---
src/backend/optimizer/plan/planner.c | 4 ++++
2 files changed, 17 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Etsuro Fujita 2019-05-09 10:53:25 pgsql: Doc: Update FDW documentation about GetForeignUpperPaths().
Previous Message Pavel Stehule 2019-05-09 09:12:09 Re: pgsql: Add strict_multi_assignment and too_many_rows plpgsql checks