pgsql: Fix unportable code in pgbench.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix unportable code in pgbench.
Date: 2019-04-17 21:30:36
Message-ID: E1hGs8a-0000DY-Ff@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Fix unportable code in pgbench.

The buildfarm points out that UINT64_FORMAT might not work with sscanf;
it's calibrated for our printf implementation, which might not agree
with the platform-supplied sscanf. Fall back to just accepting an
unsigned long, which is already more than the documentation promises.

Oversight in e6c3ba7fb; back-patch to v11, as that was.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a75c1d0c5d967ea2adcd7129092687cded4e7bf

Modified Files
--------------
src/bin/pgbench/pgbench.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2019-04-17 21:46:09 Re: pgsql: Fix unportable code in pgbench.
Previous Message Tom Lane 2019-04-17 21:06:57 pgsql: Fix assorted minor bogosity in GSSAPI transport error messages.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-04-17 21:39:01 Re: pg_dump is broken for partition tablespaces
Previous Message Stephen Frost 2019-04-17 21:20:03 Re: block-level incremental backup