pgsql: Improve readability of some tests in strings.sql

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve readability of some tests in strings.sql
Date: 2019-04-04 01:30:07
Message-ID: E1hBrCh-0003he-NL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve readability of some tests in strings.sql

c251336 has added some tests to check if a toast relation should be
empty or not, hardcoding the toast relation name when calling
pg_relation_size(). pg_class.reltoastrelid offers the same information,
so simplify the tests to use that.

Reviewed-by: Daniel Gustafsson
Discussion: https://postgr.es/m/20190403065949.GH3298@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/92c76021aed47daa61afd5c7d6f8201382dee203

Modified Files
--------------
src/test/regress/expected/strings.out | 14 ++++++++------
src/test/regress/sql/strings.sql | 6 ++++--
2 files changed, 12 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-04-04 02:00:57 Re: pgsql: Consistently test for in-use shared memory.
Previous Message Andres Freund 2019-04-04 00:42:06 pgsql: tableam: basic documentation.