pgsql: Restrict pgbench's zipfian parameter to ensure good performance.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Restrict pgbench's zipfian parameter to ensure good performance.
Date: 2019-04-01 21:37:42
Message-ID: E1hB4cg-0000PL-FZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Restrict pgbench's zipfian parameter to ensure good performance.

Remove the code that supported zipfian distribution parameters less
than 1.0, as it had undocumented performance hazards, and it's not
clear that the case is useful enough to justify either fixing or
documenting those hazards.

Also, since the code path for parameter > 1.0 could perform badly
for values very close to 1.0, establish a minimum allowed value
of 1.001. This solution seems superior to the previous vague
documentation warning about small values not performing well.

Fabien Coelho, per a gripe from Tomas Vondra

Discussion: https://postgr.es/m/b5e172e9-ad22-48a3-86a3-589afa20e8f7@2ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/26a76cb64072df6fa5585c2c15df39970ccdce01

Modified Files
--------------
doc/src/sgml/ref/pgbench.sgml | 27 ++---
src/bin/pgbench/pgbench.c | 167 +++------------------------
src/bin/pgbench/t/001_pgbench_with_server.pl | 31 +----
3 files changed, 32 insertions(+), 193 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-04-01 21:45:20 pgsql: tableam: Add table_finish_bulk_insert().
Previous Message Thomas Munro 2019-04-01 20:37:06 Re: pgsql: Compute XID horizon for page level index vacuum on primary.