pgsql: Fix volatile vs. pointer confusion

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix volatile vs. pointer confusion
Date: 2019-03-14 07:46:59
Message-ID: E1h4L4t-0002Z4-Cj@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix volatile vs. pointer confusion

Variables used after a longjmp() need to be declared volatile. In
case of a pointer, it's the pointer itself that needs to be declared
volatile, not the pointed-to value. So we need

PyObject *volatile items;

instead of

volatile PyObject *items; /* wrong */

Discussion: https://www.postgresql.org/message-id/flat/f747368d-9e1a-c46a-ac76-3c27da32e8e4%402ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1226d932b4dadc39ba2f9a488e4d784443ea6a78

Modified Files
--------------
contrib/hstore_plpython/hstore_plpython.c | 9 ++++-----
contrib/jsonb_plpython/jsonb_plpython.c | 9 +++------
2 files changed, 7 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2019-03-14 08:28:16 Re: pgsql: Add support for hyperbolic functions, as well as log10().
Previous Message Michael Paquier 2019-03-14 05:16:50 pgsql: Fix thinko when bumping on temporary directories in pg_checksums