pgsql: Fix race condition in recently-added TAP test for recovery consi

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix race condition in recently-added TAP test for recovery consi
Date: 2019-03-14 03:47:14
Message-ID: E1h4HKs-00064l-O5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix race condition in recently-added TAP test for recovery consistency

A couple of queries are run on the primary to create and fill in a test
table, which gets checked on the standby afterwards. However the test
was not waiting for the confirmation that the necessary records have
been replayed on the standby, leading to spurious failures.

Per buildfarm member loach. Thanks to Thomas Munro for the report and
Tom Lane for the failure analysis.

Discussion: https://postgr.es/m/CA+hUKGLUpqG52xtriUz5RpmeKPoEfNxNc-CginG+Cx+X2-Ycew@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/364298be22090769da14aa749fe730cf16ed3c2c

Modified Files
--------------
src/test/recovery/t/016_min_consistency.pl | 4 ++++
1 file changed, 4 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-03-14 03:51:13 Re: pgsql: Use condition variables to wait for checkpoints.
Previous Message Kyotaro HORIGUCHI 2019-03-14 03:30:00 Re: pgsql: Add support for hyperbolic functions, as well as log10().