pgsql: pgbench: increase the maximum number of variables/arguments

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgbench: increase the maximum number of variables/arguments
Date: 2019-03-11 17:18:48
Message-ID: E1h3OZc-0002dB-UX@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgbench: increase the maximum number of variables/arguments

pgbench's arbitrary limit of 10 arguments for SQL statements or
metacommands is far too low. Increase it to 256.

This results in a very modest increase in memory usage, not enough to
worry about.

The maximum includes the SQL statement or metacommand. This is reflected
in the comments and revised TAP tests.

Simon Riggs and Dagfinn Ilmari Mannsåker with some light editing by me.
Reviewed by: David Rowley and Fabien Coelho

Discussion: https://postgr.es/m/CANP8+jJiMJOAf-dLoHuR-8GENiK+eHTY=Omw38Qx7j2g0NDTXA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a47841528107921f02c280e0c5f91c5a1d86adb0

Modified Files
--------------
doc/src/sgml/ref/pgbench.sgml | 2 ++
src/bin/pgbench/pgbench.c | 15 ++++++++++++++-
src/bin/pgbench/t/001_pgbench_with_server.pl | 28 +++++-----------------------
3 files changed, 21 insertions(+), 24 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2019-03-11 19:30:22 Re: pgsql: Removed unused variable, openLogOff.
Previous Message Andres Freund 2019-03-11 17:03:32 Re: pgsql: tableam: introduce table AM infrastructure.