pgsql: Move hash_any prototype from access/hash.h to utils/hashutils.h

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Move hash_any prototype from access/hash.h to utils/hashutils.h
Date: 2019-03-11 16:25:25
Message-ID: E1h3Njx-0001Sp-PT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Move hash_any prototype from access/hash.h to utils/hashutils.h

... as well as its implementation from backend/access/hash/hashfunc.c to
backend/utils/hash/hashfn.c.

access/hash is the place for the hash index AM, not really appropriate
for generic facilities, which is what hash_any is; having things the old
way meant that anything using hash_any had to include the AM's include
file, pointlessly polluting its namespace with unrelated, unnecessary
cruft.

Also move the HTEqual strategy number to access/stratnum.h from
access/hash.h.

To avoid breaking third-party extension code, add an #include
"utils/hashutils.h" to access/hash.h. (An easily removed line by
committers who enjoy their asbestos suits to protect them from angry
extension authors.)

Discussion: https://postgr.es/m/201901251935.ser5e4h6djt2@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/af38498d4c9b840e0e454574519459edda3871db

Modified Files
--------------
contrib/citext/citext.c | 2 +-
contrib/hstore/hstore_op.c | 2 +-
contrib/pg_stat_statements/pg_stat_statements.c | 2 +-
contrib/sepgsql/uavc.c | 2 +-
src/backend/access/common/tupdesc.c | 1 -
src/backend/access/hash/hashfunc.c | 627 +----------------------
src/backend/access/tablesample/bernoulli.c | 2 +-
src/backend/access/tablesample/system.c | 2 +-
src/backend/catalog/pg_publication.c | 1 -
src/backend/commands/publicationcmds.c | 1 -
src/backend/executor/execGrouping.c | 1 -
src/backend/executor/nodeSamplescan.c | 2 +-
src/backend/lib/bloomfilter.c | 2 +-
src/backend/nodes/bitmapset.c | 3 +-
src/backend/storage/file/sharedfileset.c | 4 +-
src/backend/tsearch/ts_typanalyze.c | 2 +-
src/backend/utils/adt/acl.c | 2 +-
src/backend/utils/adt/arrayfuncs.c | 1 -
src/backend/utils/adt/date.c | 2 +-
src/backend/utils/adt/jsonb_gin.c | 2 +-
src/backend/utils/adt/jsonb_util.c | 2 +-
src/backend/utils/adt/mac.c | 2 +-
src/backend/utils/adt/mac8.c | 2 +-
src/backend/utils/adt/network.c | 3 +-
src/backend/utils/adt/numeric.c | 2 +-
src/backend/utils/adt/pg_lsn.c | 1 -
src/backend/utils/adt/rangetypes.c | 3 +-
src/backend/utils/adt/tid.c | 2 +-
src/backend/utils/adt/timestamp.c | 1 -
src/backend/utils/adt/uuid.c | 2 +-
src/backend/utils/adt/varchar.c | 3 +-
src/backend/utils/adt/varlena.c | 2 +-
src/backend/utils/cache/catcache.c | 1 -
src/backend/utils/cache/relcache.c | 1 -
src/backend/utils/hash/hashfn.c | 632 +++++++++++++++++++++++-
src/backend/utils/resowner/resowner.c | 3 +-
src/backend/utils/sort/tuplesort.c | 2 +-
src/include/access/hash.h | 24 +-
src/include/access/stratnum.h | 7 +
src/include/utils/hashutils.h | 19 +
40 files changed, 690 insertions(+), 687 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-03-11 17:03:09 pgsql: Fix typos in commit 8586bf7ed8.
Previous Message Michael Meskes 2019-03-11 15:27:08 pgsql: Fix potential memory access violation in ecpg if filename of inc