From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Solve cross-version-upgrade testing problem induced by 1fb57af92 |
Date: | 2019-02-10 02:02:26 |
Message-ID: | E1gseRu-0007kR-St@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Solve cross-version-upgrade testing problem induced by 1fb57af92.
Renaming varchar_transform to varchar_support had a side effect
I hadn't foreseen: the core regression tests leave around a
transform object that relies on that function, so the name
change breaks cross-version upgrade tests, because the name
used in the older branches doesn't match.
Since the dependency on varchar_transform was chosen with the
aid of a dartboard anyway (it would surely not work as a
language transform support function), fix by just choosing
a different random builtin function with the right signature.
Also add some comments explaining why this isn't horribly unsafe.
I chose to make the same substitution in a couple of other
copied-and-pasted test cases, for consistency, though those
aren't directly contributing to the testing problem.
Per buildfarm. Back-patch, else it doesn't fix the problem.
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4b235947c7c63a084a90c2e049d79a09ff03b9b3
Modified Files
--------------
src/bin/pg_dump/t/002_pg_dump.pl | 4 ++--
src/test/modules/test_ddl_deparse/expected/create_transform.out | 6 ++++--
src/test/modules/test_ddl_deparse/sql/create_transform.sql | 6 ++++--
src/test/regress/expected/object_address.out | 4 +++-
src/test/regress/sql/object_address.sql | 4 +++-
5 files changed, 16 insertions(+), 8 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2019-02-10 06:14:32 | Re: pgsql: Use better comment marker in Autoconf input |
Previous Message | Tom Lane | 2019-02-10 00:45:58 | pgsql: Repair unsafe/unportable snprintf usage in pg_restore. |