pgsql: Refactor planner's header files.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor planner's header files.
Date: 2019-01-29 20:49:03
Message-ID: E1goaJb-0002mt-JL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor planner's header files.

Create a new header optimizer/optimizer.h, which exposes just the
planner functions that can be used "at arm's length", without need
to access Paths or the other planner-internal data structures defined
in nodes/relation.h. This is intended to provide the whole planner
API seen by most of the rest of the system; although FDWs still need
to use additional stuff, and more thought is also needed about just
what selfuncs.c should rely on.

The main point of doing this now is to limit the amount of new
#include baggage that will be needed by "planner support functions",
which I expect to introduce later, and which will be in relevant
datatype modules rather than anywhere near the planner.

This commit just moves relevant declarations into optimizer.h from
other header files (a couple of which go away because everything
got moved), and adjusts #include lists to match. There's further
cleanup that could be done if we want to decide that some stuff
being exposed by optimizer.h doesn't belong in the planner at all,
but I'll leave that for another day.

Discussion: https://postgr.es/m/11460.1548706639@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f09346a9c6218dd239fdf3a79a729716c0d305bd

Modified Files
--------------
contrib/bloom/blcost.c | 1 -
contrib/file_fdw/file_fdw.c | 3 +-
contrib/postgres_fdw/deparse.c | 3 +-
contrib/postgres_fdw/postgres_fdw.c | 2 +-
contrib/tsm_system_rows/tsm_system_rows.c | 3 +-
contrib/tsm_system_time/tsm_system_time.c | 3 +-
src/backend/access/gist/gistbuild.c | 2 +-
src/backend/access/spgist/spgutils.c | 4 -
src/backend/access/tablesample/bernoulli.c | 3 +-
src/backend/access/tablesample/system.c | 3 +-
src/backend/access/transam/parallel.c | 2 +-
src/backend/catalog/heap.c | 4 +-
src/backend/catalog/index.c | 3 +-
src/backend/catalog/partition.c | 4 +-
src/backend/commands/cluster.c | 2 +-
src/backend/commands/copy.c | 4 +-
src/backend/commands/explain.c | 2 -
src/backend/commands/functioncmds.c | 3 +-
src/backend/commands/indexcmds.c | 4 +-
src/backend/commands/tablecmds.c | 6 +-
src/backend/commands/trigger.c | 3 +-
src/backend/commands/typecmds.c | 2 +-
src/backend/executor/execExpr.c | 3 +-
src/backend/executor/execMain.c | 1 -
src/backend/executor/execParallel.c | 2 -
src/backend/executor/nodeAgg.c | 3 +-
src/backend/executor/nodeGather.c | 2 +-
src/backend/executor/nodeGatherMerge.c | 2 +-
src/backend/executor/nodeIndexscan.c | 1 -
src/backend/executor/nodeWindowAgg.c | 2 +-
src/backend/jit/llvm/llvmjit_expr.c | 1 -
src/backend/optimizer/path/allpaths.c | 2 +-
src/backend/optimizer/path/clausesel.c | 1 +
src/backend/optimizer/path/costsize.c | 1 +
src/backend/optimizer/path/equivclass.c | 2 +-
src/backend/optimizer/path/indxpath.c | 3 +-
src/backend/optimizer/path/pathkeys.c | 3 +-
src/backend/optimizer/path/tidpath.c | 2 +-
src/backend/optimizer/plan/analyzejoins.c | 2 +-
src/backend/optimizer/plan/createplan.c | 3 +-
src/backend/optimizer/plan/initsplan.c | 2 +-
src/backend/optimizer/plan/planagg.c | 1 +
src/backend/optimizer/plan/planmain.c | 1 +
src/backend/optimizer/plan/planner.c | 2 +-
src/backend/optimizer/plan/setrefs.c | 1 +
src/backend/optimizer/plan/subselect.c | 2 +-
src/backend/optimizer/prep/prepjointree.c | 2 +-
src/backend/optimizer/prep/prepqual.c | 2 +-
src/backend/optimizer/prep/preptlist.c | 2 +-
src/backend/optimizer/util/clauses.c | 2 +-
src/backend/optimizer/util/orclauses.c | 1 +
src/backend/optimizer/util/pathnode.c | 2 +-
src/backend/optimizer/util/placeholder.c | 2 +-
src/backend/optimizer/util/plancat.c | 2 +-
src/backend/optimizer/util/predtest.c | 4 +-
src/backend/optimizer/util/restrictinfo.c | 2 +-
src/backend/optimizer/util/tlist.c | 1 +
src/backend/optimizer/util/var.c | 2 +-
src/backend/parser/analyze.c | 2 +-
src/backend/parser/parse_agg.c | 3 +-
src/backend/parser/parse_clause.c | 3 +-
src/backend/parser/parse_expr.c | 3 +-
src/backend/parser/parse_utilcmd.c | 4 +-
src/backend/partitioning/partbounds.c | 1 -
src/backend/partitioning/partprune.c | 6 +-
src/backend/replication/logical/worker.c | 27 +---
src/backend/rewrite/rewriteManip.c | 2 +-
src/backend/statistics/dependencies.c | 3 +-
src/backend/tcop/postgres.c | 2 +-
src/backend/utils/adt/array_selfuncs.c | 1 -
src/backend/utils/adt/orderedsetaggs.c | 2 +-
src/backend/utils/adt/ruleutils.c | 2 +-
src/backend/utils/adt/selfuncs.c | 3 +-
src/backend/utils/cache/partcache.c | 3 +-
src/backend/utils/cache/plancache.c | 5 +-
src/backend/utils/cache/relcache.c | 4 +-
src/backend/utils/cache/spccache.c | 2 +-
src/backend/utils/cache/typcache.c | 2 +-
src/backend/utils/misc/guc.c | 1 +
src/include/nodes/relation.h | 22 +++-
src/include/optimizer/clauses.h | 13 --
src/include/optimizer/cost.h | 34 +----
src/include/optimizer/optimizer.h | 175 +++++++++++++++++++++++++
src/include/optimizer/planmain.h | 14 --
src/include/optimizer/planner.h | 14 +-
src/include/optimizer/predtest.h | 25 ----
src/include/optimizer/prep.h | 6 -
src/include/optimizer/tlist.h | 16 ---
src/include/optimizer/var.h | 40 ------
src/pl/plpgsql/src/pl_exec.c | 3 +-
src/test/modules/test_predtest/test_predtest.c | 3 +-
91 files changed, 278 insertions(+), 303 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-01-29 21:49:32 pgsql: Rename nodes/relation.h to nodes/pathnodes.h.
Previous Message Christoph Berg 2019-01-29 15:55:29 Re: pgsql: Build src/port files as a library with -fPIC, and use that in li