pgsql: Revert "Add valgrind suppressions for wcsrtombs optimizations"

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert "Add valgrind suppressions for wcsrtombs optimizations"
Date: 2019-01-19 19:43:16
Message-ID: E1gkwWS-0001yI-Oi@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "Add valgrind suppressions for wcsrtombs optimizations"

This reverts commit 71b2951ccc433a6dd799efedff9f5927c32440f6.

Per discussion, it's not desirable to add valgrind suppressions for
outside our own code base (e.g. glibc in this case), especially when
the suppressions may be platform-specific. There are better ways to
deal with that, e.g. by providing local suppressions.

Discussion: https://www.postgresql.org/message-id/flat/90ac0452-e907-e7a4-b3c8-15bd33780e62%402ndquadrant.com

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/058e2757b9bf44968af4cc93cd8334e3dba6f362

Modified Files
--------------
src/tools/valgrind.supp | 36 ------------------------------------
1 file changed, 36 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2019-01-19 19:45:50 pgsql: Revert "Add valgrind suppressions for wcsrtombs optimizations"
Previous Message Tomas Vondra 2019-01-19 19:42:12 pgsql: Revert "Add valgrind suppressions for wcsrtombs optimizations"