| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix portability failure introduced in commits d2b0b60e7 et al. |
| Date: | 2018-12-26 20:30:58 |
| Message-ID: | E1gcFpS-00082c-Je@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix portability failure introduced in commits d2b0b60e7 et al.
I made a frontend fprintf() format use %m, forgetting that that's only
safe in HEAD not the back branches; prior to 96bf88d52 and d6c55de1f,
it would work on glibc platforms but not elsewhere. Revert to using
%s ... strerror(errno) as the code did before.
We could have left HEAD as-is, but for code consistency across branches,
I chose to apply this patch there too.
Per Coverity and a few buildfarm members.
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/47c93ace9fd1e3ed90defb3a478ad2287342b22d
Modified Files
--------------
src/common/psprintf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-12-26 21:08:23 | pgsql: Fix failure to check for open() or fsync() failures. |
| Previous Message | Michael Paquier | 2018-12-25 05:26:48 | pgsql: Improve tab completion of ALTER INDEX/TABLE with SET STATISTICS |