pgsql: Cleanup minor pg_dump memory leaks

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Cleanup minor pg_dump memory leaks
Date: 2018-12-06 16:11:57
Message-ID: E1gUwFp-0005TG-8q@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Cleanup minor pg_dump memory leaks

In dumputils, we may have successfully parsed the acls when we discover
that we can't parse the reverse ACLs and then return- check and free
aclitems if that happens.

In dumpTableSchema, move ftoptions and srvname under the relkind !=
RELKIND_VIEW branch (since they're only used there) and then check if
they've been allocated and, if so, free them at the end of that block.

Pointed out by Pavel Raiskup, though I didn't use those patches.

Discussion: https://postgr.es/m/2183976.vkCJMhdhmF@nb.usersys.redhat.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/369d494a4f5c1494a46adcf5c56f5462a83ef20d

Modified Files
--------------
src/bin/pg_dump/dumputils.c | 2 ++
src/bin/pg_dump/pg_dump.c | 14 ++++++++------
2 files changed, 10 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2018-12-06 16:39:41 pgsql: Improve planner stats documentation
Previous Message Stephen Frost 2018-12-06 16:06:17 pgsql: Cleanup comments in xlog compression