From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Only allow one recovery target setting |
Date: | 2018-11-28 13:25:06 |
Message-ID: | E1gRzpy-0000j5-NQ@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Only allow one recovery target setting
The previous recovery.conf regime accepted multiple recovery_target*
settings and used the last one. This does not translate well to the
general GUC system. Specifically, under EXEC_BACKEND, the settings
are written out not in any particular order, so the order in which
they were originally set is not available to new processes.
Rather than redesign the GUC system, it was decided to abandon the old
behavior and only allow one recovery target setting. A second setting
will cause an error. However, it is allowed to set the same parameter
multiple times or unset a parameter and set a different one.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f2cbffc7a6183a359b339cfed65e9d609de756f0
Modified Files
--------------
doc/src/sgml/config.sgml | 2 +-
src/backend/utils/misc/guc.c | 46 ++++++++++++++++++++++++++---
src/test/recovery/t/003_recovery_targets.pl | 46 ++++++++++++-----------------
3 files changed, 62 insertions(+), 32 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-11-28 17:14:10 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
Previous Message | Bruce Momjian | 2018-11-28 12:34:22 | pgsql: C comment: remove extra '*' |