From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix AC_REQUIRES breakage in LLVM autoconf tests. |
Date: | 2018-11-18 04:16:29 |
Message-ID: | E1gOEVZ-0006jJ-Ov@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix AC_REQUIRES breakage in LLVM autoconf tests.
Any Autoconf macro that uses AC_REQUIRES -- directly or indirectly --
must not be inside a plain shell "if" test; if it is, whatever code
gets pulled in by the AC_REQUIRES will also be inside that "if".
Instead of "if" we can use AS_IF, which knows how to get this right
(cf commit 01051a987).
The only immediate problem from getting this wrong was that AC_PROG_AWK
had to be run twice, once inside the "if llvm" block and once in the
main line. However, it broke a different patch I'm about to submit
more thoroughly.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0b59b0e8bcc9e85bad6fffa7828344db1a36f20a
Modified Files
--------------
configure | 46 ++--------------------------------------------
configure.in | 6 ++----
2 files changed, 4 insertions(+), 48 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2018-11-18 17:42:02 | pgsql: Silence MSVC warnings about redefinition of isnan |
Previous Message | Tomas Vondra | 2018-11-17 23:10:27 | pgsql: Add valgrind suppressions for wcsrtombs optimizations |