pgsql: Adjust trace_sort log messages.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Adjust trace_sort log messages.
Date: 2018-11-01 16:20:27
Message-ID: E1gIFhr-0004oP-MI@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Adjust trace_sort log messages.

The project message style guide dictates: "When citing the name of an
object, state what kind of object it is". The parallel CREATE INDEX
patch added a worker number to most of the trace_sort messages within
tuplesort.c without specifying the object type. Bring these messages
into compliance with the style guide.

We're still treating a leader or serial Tuplesortstate as having worker
number -1. trace_sort is a developer option, and these two cases are
highly comparable, so this seems appropriate.

Per complaint from Tom Lane.

Discussion: https://postgr.es/m/8330.1540831863@sss.pgh.pa.us
Backpatch: 11-, where parallel CREATE INDEX was introduced.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cb6f8a9a7243d398c76f9299a1b601270834d303

Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2018-11-01 16:20:39 pgsql: Adjust trace_sort log messages.
Previous Message Michael Paquier 2018-11-01 06:09:11 Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot