pgsql: Use whitelist to choose files scanned with pg_verify_checksums

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use whitelist to choose files scanned with pg_verify_checksums
Date: 2018-10-19 13:49:57
Message-ID: E1gDVA5-0007N2-G9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use whitelist to choose files scanned with pg_verify_checksums

The original implementation of pg_verify_checksums used a blacklist to
decide which files should be skipped for scanning as they do not include
data checksums, like pg_internal.init or pg_control. However, this
missed two things:
- Some files are created within builds of EXEC_BACKEND and these were
not listed, causing failures on Windows.
- Extensions may create custom files in data folders, causing the tool
to equally fail.

This commit switches to a whitelist-like method instead by checking if
the files to scan are authorized relation files. This is close to a
reverse-engineering of what is defined in relpath.c in charge of
building the relation paths, and we could consider refactoring what this
patch does so as all routines are in a single place. This is left for
later.

This is based on a suggestion from Andres Freund. TAP tests are updated
so as multiple file patterns are tested. The bug has been spotted by
various buildfarm members as a result of b34e84f which has introduced
the TAP tests of pg_verify_checksums.

Author: Michael Paquier
Reviewed-by: Andrew Dunstan, Michael Banck
Discussion: https://postgr.es/m/20181012005614.GC26424@paquier.xyz
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d55241af705667d4503638e3f77d3689fd6be31d

Modified Files
--------------
src/bin/pg_verify_checksums/pg_verify_checksums.c | 79 +++++++++++++++++------
src/bin/pg_verify_checksums/t/002_actions.pl | 56 +++++++++++++++-
2 files changed, 116 insertions(+), 19 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-10-19 13:50:09 Re: pgsql: Add TAP tests for pg_verify_checksums
Previous Message Tom Lane 2018-10-19 04:50:39 pgsql: Add missing quote_identifier calls for CREATE TRIGGER ... REFERE