pgsql: Select appropriate PG_PRINTF_ATTRIBUTE for recent NetBSD.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Select appropriate PG_PRINTF_ATTRIBUTE for recent NetBSD.
Date: 2018-10-09 15:10:14
Message-ID: E1g9teI-0000Jo-Ei@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Select appropriate PG_PRINTF_ATTRIBUTE for recent NetBSD.

NetBSD-current generates a large number of warnings about "%m" not
being appropriate to use with *printf functions. While that's true
for their native printf, it's surely not true for snprintf.c, so I
think they have misunderstood gcc's definition of the "gnu_printf"
archetype. Nonetheless, choosing "__syslog__" instead silences the
warnings; so teach configure about that.

Since this is only a cosmetic warning issue (and anyway it depends
on previous hacking to be self-consistent), no back-patch.

Discussion: https://postgr.es/m/16785.1539046036@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/aed9fa0bd8973fd967724003e641a5b7054d6a80

Modified Files
--------------
config/c-compiler.m4 | 35 +++++++++++++++++++++++++----------
configure | 41 +++++++++++++++++++++++++++++++++++------
src/include/pg_config.h.in | 2 +-
3 files changed, 61 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-10-09 15:31:46 pgsql: Remove no-longer-needed variant expected regression result files
Previous Message Michael Paquier 2018-10-09 13:38:25 pgsql: Add pg_ls_archive_statusdir function