pgsql: Allow btree comparison functions to return INT_MIN.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allow btree comparison functions to return INT_MIN.
Date: 2018-10-05 20:01:53
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Allow btree comparison functions to return INT_MIN.

Historically we forbade datatype-specific comparison functions from
returning INT_MIN, so that it would be safe to invert the sort order
just by negating the comparison result. However, this was never
really safe for comparison functions that directly return the result
of memcmp(), strcmp(), etc, as POSIX doesn't place any such restriction
on those library functions. Buildfarm results show that at least on
recent Linux on s390x, memcmp() actually does return INT_MIN sometimes,
causing sort failures.

The agreed-on answer is to remove this restriction and fix relevant
call sites to not make such an assumption; code such as "res = -res"
should be replaced by "INVERT_COMPARE_RESULT(res)". The same is needed
in a few places that just directly negated the result of memcmp or

To help find places having this problem, I've also added a compile option
to nbtcompare.c that causes some of the commonly used comparators to
return INT_MIN/INT_MAX instead of their usual -1/+1. It'd likely be
a good idea to have at least one buildfarm member running with
"-DSTRESS_SORT_INT_MIN". That's far from a complete test of course,
but it should help to prevent fresh introductions of such bugs.

This is a longstanding portability hazard, so back-patch to all supported




Modified Files
contrib/ltree/ltree_op.c | 11 ++++-
contrib/pgcrypto/imath.c | 15 +++----
src/backend/access/nbtree/nbtcompare.c | 77 +++++++++++++++++++++-------------
src/backend/access/nbtree/nbtsearch.c | 2 +-
src/backend/access/nbtree/nbtutils.c | 4 +-
src/backend/executor/nodeGatherMerge.c | 5 ++-
src/backend/executor/nodeIndexscan.c | 7 ++--
src/backend/executor/nodeMergeAppend.c | 5 ++-
src/bin/pg_rewind/filemap.c | 2 +-
src/include/access/nbtree.h | 3 +-
src/include/c.h | 8 ++++
src/include/utils/sortsupport.h | 7 ++--
12 files changed, 90 insertions(+), 56 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2018-10-05 21:20:36 pgsql: doc: update PG 11 release notes
Previous Message David Steele 2018-10-05 17:03:44 Re: pgsql: Make WAL segment size configurable at initdb time.