pgsql: Fix bogus tab-completion rule for CREATE PUBLICATION.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix bogus tab-completion rule for CREATE PUBLICATION.
Date: 2018-09-21 19:58:44
Message-ID: E1g3RZc-0008Ig-0b@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus tab-completion rule for CREATE PUBLICATION.

You can't use "FOR TABLE" as a single Matches argument, because readline
will consider that input to be two words not one. It's necessary to make
the pattern contain two arguments.

The case accidentally worked anyway because the words_after_create
test fired ... but only for the first such table name.

Noted by Edmund Horner, though this isn't exactly his proposed fix.
Backpatch to v10 where the faulty code came in.

Discussion: https://postgr.es/m/CAMyN-kDe=gBmHgxWwUUaXuwK+p+7g1vChR7foPHRDLE592nJPQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e8fe426baa9c242d8dbd4eab1d963e952c9172f4

Modified Files
--------------
src/bin/psql/tab-complete.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2018-09-21 23:55:23 pgsql: docs: remove use of escape strings and use bytea hex output
Previous Message Tom Lane 2018-09-21 19:22:32 pgsql: Improve tab completion for ANALYZE, EXPLAIN, and VACUUM.