pgsql: Revert "Allow concurrent-safe open() and fopen() in frontend cod

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert "Allow concurrent-safe open() and fopen() in frontend cod
Date: 2018-09-18 21:34:23
Message-ID: E1g2NdX-0007op-4b@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "Allow concurrent-safe open() and fopen() in frontend code for Windows"

This reverts commit f02259fe93e75d5443a2fabe2f2f38b81924ab36, in the
v11 branch only.

The hack this required in initdb.c should probably have clued us that it
wasn't really ready, but we didn't get the hint. Subsequent developments
have made clear that it affected text-vs-binary behavior in a lot of
places, and there's no reason to think that any of those behavioral changes
are desirable. There's no time to fix this before 11beta4, so just revert
for the moment. We can keep working on this in HEAD, and maybe reconsider
a back-patch once we're satisfied things are stable.

(I take the blame for this fiasco, having encouraged Michael to back-patch
a change at the last possible moment before beta wrap.)

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/df8b5f3eb8a7c477156d0ad9d83e7297912cfe79

Modified Files
--------------
src/bin/initdb/initdb.c | 8 --------
src/bin/pg_basebackup/pg_receivewal.c | 2 +-
src/bin/pg_verify_checksums/pg_verify_checksums.c | 2 +-
src/common/file_utils.c | 4 ++--
src/include/port.h | 3 +++
5 files changed, 7 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-09-18 21:38:07 Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi
Previous Message Tom Lane 2018-09-18 21:12:08 pgsql: Add a debugging option to stress-test outfuncs.c and readfuncs.c