pgsql: libpq: Change "options" dispchar to normal

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: libpq: Change "options" dispchar to normal
Date: 2018-09-07 13:13:22
Message-ID: E1fyGZe-0002qJ-Is@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

libpq: Change "options" dispchar to normal

libpq connection options as returned by PQconndefaults() have a
"dispchar" field that determines (among other things) whether an option
is a "debug" option, which shouldn't be shown by default to clients.
postgres_fdw makes use of that to control which connection options to
accept from a foreign server configuration.

Curiously, the "options" option, which allows passing configuration
settings to the backend server, was listed as a debug option, which
prevented it from being used by postgres_fdw. Maybe it was once meant
for debugging, but it's clearly in general use nowadays.

So change the dispchar for it to be the normal non-debug case. Also
remove the "debug" reference from its label field.

Reported-by: Shinoda, Noriyoshi <noriyoshi(dot)shinoda(at)hpe(dot)com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1fea1e325492b10f645809204631426bb6abbe6e

Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Gierth 2018-09-07 13:40:07 pgsql: Refactor installation of extension headers.
Previous Message Peter Eisentraut 2018-09-07 09:47:29 Re: pgsql: Refactor dlopen() support