pgsql: Allow extensions to install built as well as unbuilt headers.

From: Andrew Gierth <rhodiumtoad(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allow extensions to install built as well as unbuilt headers.
Date: 2018-09-05 21:45:49
Message-ID: E1fxfcT-00069A-V6@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Allow extensions to install built as well as unbuilt headers.

Commit df163230b overlooked the case that an out-of-tree extension
might need to build its header files (e.g. via ./configure). If it is
also doing a VPATH build, the HEADERS_* rules in the original commit
would then fail to find the files, since they would be looking only
under $(srcdir) and not in the build directory.

Fix by adding HEADERS_built and HEADERS_built_$(MODULE) which behave
like DATA_built in that they look in the build dir rather than the
source dir (and also make the files dependencies of the "all" target).

No Windows support appears to be needed for this, since it is only
relevant to out-of-tree builds (no support exists in Mkvcbuild.pm to
build extension header files in any case).

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/be54b3777ff189e79661d8746d3f25b0564393d2

Modified Files
--------------
doc/src/sgml/extend.sgml | 16 +++++++++++++---
src/makefiles/pgxs.mk | 49 +++++++++++++++++++++++++++++++++++++++---------
2 files changed, 53 insertions(+), 12 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-09-06 01:50:15 Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.
Previous Message Michael Paquier 2018-09-05 20:05:42 Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.

Browse pgsql-hackers by date

  From Date Subject
Next Message R, Siva 2018-09-05 21:49:05 Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun
Previous Message Victor Spirin 2018-09-05 21:25:28 Re: PostgreSQL does not start when max_files_per_process> 1200 on Windows 7