pgsql: Fix psql's \dC command to annotate I/O conversion casts as such.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix psql's \dC command to annotate I/O conversion casts as such.
Date: 2018-08-31 20:45:44
Message-ID: E1fvqIa-0004Uo-OY@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix psql's \dC command to annotate I/O conversion casts as such.

A cast declared WITH INOUT was described as '(binary coercible)',
which seems pretty inaccurate; let's print '(with inout)' instead.
Per complaint from Jean-Pierre Pelletier.

This definitely seems like a bug fix, but given that it's been wrong
since 8.4 and nobody complained before, I'm hesitant to back-patch a
behavior change into stable branches. It doesn't seem too late for
v11 though.

Discussion: https://postgr.es/m/5b887023.1c69fb81.ff96e.6a1d@mx.google.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ed9c336b0f6bcf08e7b6bbe7080fdb63640a680e

Modified Files
--------------
src/bin/psql/describe.c | 56 +++++++++++++++++++++++++++++++++----------------
1 file changed, 38 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-09-01 00:11:58 pgsql: Fix 8a934d677 for libc++ and make more include order resistant.
Previous Message Michael Paquier 2018-08-31 18:07:49 pgsql: Ensure correct minimum consistent point on standbys