pgsql: Enforce cube dimension limit in all cube construction functions

From: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Enforce cube dimension limit in all cube construction functions
Date: 2018-08-31 17:21:47
Message-ID: E1fvn7D-0000IS-RZ@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Enforce cube dimension limit in all cube construction functions

contrib/cube has a limit to 100 dimensions for cube datatype. However, it's
not enforced everywhere, and one can actually construct cube with more than
100 dimensions having then trouble with dump/restore. This commit add checks
for dimensions limit in all functions responsible for cube construction.
Backpatch to all supported versions.

Reported-by: Andrew Gierth
Discussion: https://postgr.es/m/87va7uybt4.fsf%40news-spur.riddles.org.uk
Author: Andrey Borodin with small additions by me
Review: Tom Lane
Backpatch-through: 9.3

Branch
------
REL9_3_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9f3ade1a6f62dd0315aa14b615666e0d54054763

Modified Files
--------------
contrib/cube/cube.c | 34 ++++++++++++++++++++++++++++++++++
contrib/cube/expected/cube.out | 40 ++++++++++++++++++++++++++++++++++++++++
contrib/cube/sql/cube.sql | 18 +++++++++++++++++-
3 files changed, 91 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2018-08-31 17:22:06 pgsql: Split contrib/cube platform-depended checks into separate test
Previous Message Tom Lane 2018-08-31 16:27:50 pgsql: Make checksum_impl.h safe to compile with -fstrict-aliasing.