pgsql: pg_dump: Reorganize getTableAttrs()

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_dump: Reorganize getTableAttrs()
Date: 2018-08-30 16:42:47
Message-ID: E1fvQ1v-0004Ui-P5@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dump: Reorganize getTableAttrs()

Instead of repeating the almost same large query in each version branch,
use one query and add a few columns to the SELECT list depending on the
version. This saves a lot of duplication.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/daa9fe8a5264a3f192efa5ddee8fb011ad9da365

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 198 +++++++++++++++-------------------------------
1 file changed, 62 insertions(+), 136 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2018-08-30 17:28:29 pgsql: Add semicolons to end of internally run queries
Previous Message Alvaro Herrera 2018-08-30 09:51:46 pgsql: pg_verify_checksums: rename -d to --verbose