| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix configure's snprintf test so it exposes HP-UX bug. |
| Date: | 2018-08-17 14:38:41 |
| Message-ID: | E1fqfth-0007iW-Cq@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix configure's snprintf test so it exposes HP-UX bug.
Since commit e1d19c902, buildfarm member gharial has been failing with
symptoms indicating that snprintf sometimes returns -1 for buffer
overrun, even though it passes the added configure check. Some
google research suggests that this happens only in limited cases,
such as when the overrun happens partway through a %d item. Adjust
the configure check to exercise it that way. Since I'm now feeling
more paranoid than I was before, also make the test explicitly verify
that the buffer doesn't get physically overrun.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9bed827b18cc4f27fb7cd7c02ad301519eca6d29
Modified Files
--------------
config/c-library.m4 | 11 ++++++++---
configure | 9 ++++++---
2 files changed, 14 insertions(+), 6 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-08-17 15:31:16 | pgsql: Set scan direction appropriately for SubPlans (bug #15336) |
| Previous Message | Bruce Momjian | 2018-08-17 14:26:06 | pgsql: pg_upgrade: issue helpful error message for use on standbys |