| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove bogus Assert in make_partitionedrel_pruneinfo(). |
| Date: | 2018-08-09 00:02:55 |
| Message-ID: | E1fnYPn-0006PK-FI@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove bogus Assert in make_partitionedrel_pruneinfo().
This Assert thought that a given rel couldn't be both leaf and
non-leaf, but it turns out that in some unusual plan trees
that's wrong, so remove it.
The lack of testing for cases like that is quite concerning ---
there is little reason for confidence that there aren't other
bugs in the area. But developing a stable test case seems
rather difficult, and in any case we don't need this Assert.
David Rowley
Discussion: https://postgr.es/m/CAJGNTeOkdk=UVuMugmKL7M=owgt4nNr1wjxMg1F+mHsXyLCzFA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/59ef49d26d2f8724d0788fea0774f786a22ca63d
Modified Files
--------------
src/backend/partitioning/partprune.c | 2 --
1 file changed, 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-08-09 07:42:46 | pgsql: Restrict access to reindex of shared catalogs for non-privileged |
| Previous Message | Peter Geoghegan | 2018-08-08 19:59:21 | pgsql: Doc: Correct description of amcheck example query. |