| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix JITed EEOP_AGG_INIT_TRANS, which missed some state. |
| Date: | 2018-07-23 00:06:17 |
| Message-ID: | E1fhOMj-0004zx-2d@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix JITed EEOP_AGG_INIT_TRANS, which missed some state.
The JIT compiled implementation missed maintaining
AggState->{current_set,curaggcontext}. That could lead to trouble
because the transition value could be allocated in the wrong context.
Reported-By: Rushabh Lathia
Diagnosed-By: Dmitry Dolgov
Author: Dmitry Dolgov, with minor changes by me
Discussion: https://postgr.es/m/CAGPqQf165-=+Drw3Voim7M5EjHT1zwPF9BQRjLFQzCzYnNZEiQ@mail.gmail.com
Backpatch: 11-, where JIT compilation support was added
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6b4d860311e99621681f25db5db82f88348d8ea6
Modified Files
--------------
src/backend/jit/llvm/llvmjit_expr.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-07-23 00:06:18 | pgsql: Fix JITed EEOP_AGG_INIT_TRANS, which missed some state. |
| Previous Message | Andres Freund | 2018-07-22 22:30:20 | pgsql: Deduplicate "invalid input syntax" messages for various types. |