pgsql: Dump foreign keys on partitioned tables

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Dump foreign keys on partitioned tables
Date: 2018-07-13 17:17:18
Message-ID: E1fe1h0-0003jl-SU@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Dump foreign keys on partitioned tables

The patch that ended up as commit 3de241dba86f ("Foreign keys on
partitioned tables") lacked pg_dump tests, so the pg_dump code that was
there to support it inadvertently stopped working when in later
development I modified the backend code not to emit pg_trigger rows for
the partitioned table itself.

Bug analysis and code fix is by Michaël. I (Álvaro) added the test.

Reported-by: amul sul <sulamul(at)gmail(dot)com>
Co-authored-by: Michaël Paquier <michael(at)paquier(dot)xyz>
Co-authored-by: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://postgr.es/m/CAAJ_b94n=UsNVhgs97vCaWEZAMe-tGDRVuZ73oePQH=eaJKGSA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/93ad00c968ae93e93f4ff238068a92625f41b6ff

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 7 ++++++-
src/bin/pg_dump/t/002_pg_dump.pl | 19 +++++++++++++++++++
2 files changed, 25 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-07-13 18:17:06 pgsql: Fix crash in json{b}_populate_recordset() and json{b}_to_records
Previous Message Heikki Linnakangas 2018-07-13 16:57:01 pgsql: Improve performance of tuple conversion map generation