pgsql: Cosmetic improvement: use BKI_DEFAULT and BKI_LOOKUP in pg_langu

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Cosmetic improvement: use BKI_DEFAULT and BKI_LOOKUP in pg_langu
Date: 2018-04-29 17:26:35
Message-ID: E1fCq5r-0002Qu-Os@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Cosmetic improvement: use BKI_DEFAULT and BKI_LOOKUP in pg_language.

The point of this is not really to remove redundancy in pg_language.dat;
with only three entries, it's hardly worth it. Rather, it is to get
to a point where there are exactly zero hard-coded numeric pg_proc OID
references in the catalog .dat files. The lanvalidator column was the
only remaining location of such references, and it seems like a good
thing for future-proofing reasons to make it not be a special case.

There are still a few places in the .dat files with numeric OID references
to other catalogs, but after review I don't see any that seem worth
changing at present. In each case there are just too few entries to make
it worth the trouble to create lookup infrastructure.

This doesn't change the emitted postgres.bki file, so no catversion bump.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/85475afdb6f4f630f2071235373a986e472a117b

Modified Files
--------------
src/include/catalog/pg_language.dat | 12 +++---------
src/include/catalog/pg_language.h | 30 ++++++++++++++++++++++--------
2 files changed, 25 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-29 19:21:59 pgsql: Avoid wrong results for power() with NaN input on some platforms
Previous Message Tom Lane 2018-04-28 21:45:09 pgsql: In AtEOXact_Files, complain if any files remain unclosed at comm