pgsql: Clarify handling of special-case values in bootstrap catalog dat

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Clarify handling of special-case values in bootstrap catalog dat
Date: 2018-04-28 19:27:20
Message-ID: E1fCVVA-0001GW-JT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Clarify handling of special-case values in bootstrap catalog data.

I (tgl) originally coded the special case for pg_proc.pronargs as
though it were a kind of default value. It seems better though to
treat computable columns as an independent concern: this makes the
code clearer, and probably a bit faster too since we needn't do
work inside the per-column loop.

Improve related comments, as well, in the expectation that there
might be more cases like this in future.

John Naylor, some additional comment-hacking by me

Discussion: https://postgr.es/m/CAJVSVGW-D7OobzU=dybVT2JqZAx-4X1yvBJdavBmqQL05Q6CLw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/45c6d75f8cd2399181063b4e0ec11c2664ebeda6

Modified Files
--------------
src/backend/catalog/Catalog.pm | 24 ++++++++++++++++--------
src/include/catalog/pg_proc.dat | 3 +++
src/include/catalog/reformat_dat_file.pl | 18 +++++++++---------
3 files changed, 28 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-28 20:09:11 pgsql: Tweak reformat_dat_file.pl to make it more easily hand-invokable
Previous Message Tom Lane 2018-04-28 18:45:45 pgsql: Un-break contrib install with llvm.