pgsql: Make bms_prev_member work correctly with a 64 bit bitmapword

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make bms_prev_member work correctly with a 64 bit bitmapword
Date: 2018-04-23 14:59:53
Message-ID: E1fAcwb-0003eQ-8B@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make bms_prev_member work correctly with a 64 bit bitmapword

5c067521 erroneously had coded bms_prev_member assuming that a bitmapword
would always hold 32 bits and started it's search on what it thought was the
highest 8-bits of the word. This was not the case if bitmapwords were 64
bits.

In passing add a test to exercise this function a little. Previously there was
no coverage at all.

David Rowly

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a5ab8928d7d9e2cf76ed0590efbd9795ea9e5b5e

Modified Files
--------------
src/backend/nodes/bitmapset.c | 2 +-
src/test/regress/expected/partition_prune.out | 23 +++++++++++++++++++++++
src/test/regress/sql/partition_prune.sql | 25 +++++++++++++++++++++++++
3 files changed, 49 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-04-23 15:12:34 pgsql: Remove useless default clause in switch
Previous Message Teodor Sigaev 2018-04-23 13:55:30 pgsql: Update trigram example in docs to correct state