pgsql: Switch client-side code to include catalog/pg_foo_d.h not pg_foo

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Switch client-side code to include catalog/pg_foo_d.h not pg_foo
Date: 2018-04-08 17:59:55
Message-ID: E1f5Ebb-0005aO-FH@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Switch client-side code to include catalog/pg_foo_d.h not pg_foo.h.

Everything of use to frontend code should now appear in the _d.h files,
and making this change frees us from needing to worry about whether the
catalog header files proper are frontend-safe.

Remove src/interfaces/ecpg/ecpglib/pg_type.h entirely, as the previous
commit reduced it to a confusingly-named wrapper around pg_type_d.h.

In passing, make test_rls_hooks.c follow project convention of including
our own files with #include "" not <>.

Discussion: https://postgr.es/m/23690.1523031777@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9c0a0de4c91b2dc911220d769cf2c5f754cfcb90

Modified Files
--------------
contrib/oid2name/oid2name.c | 2 +-
contrib/vacuumlo/vacuumlo.c | 2 +-
src/bin/initdb/initdb.c | 5 ++---
src/bin/pg_dump/common.c | 2 +-
src/bin/pg_dump/pg_dump.c | 22 +++++++++++-----------
src/bin/pg_dump/pg_dump_sort.c | 2 +-
src/bin/pg_rewind/filemap.c | 2 +-
src/bin/pg_rewind/libpq_fetch.c | 2 +-
src/bin/pg_upgrade/check.c | 2 +-
src/bin/pg_upgrade/function.c | 2 +-
src/bin/pg_upgrade/info.c | 2 +-
src/bin/pg_upgrade/pg_upgrade.c | 2 +-
src/bin/pg_upgrade/relfilenode.c | 2 +-
src/bin/pg_upgrade/version.c | 2 +-
src/bin/psql/command.c | 2 +-
src/bin/psql/describe.c | 6 +++---
src/bin/psql/tab-complete.c | 2 +-
src/bin/scripts/vacuumdb.c | 2 +-
src/common/relpath.c | 2 +-
src/fe_utils/print.c | 2 +-
src/interfaces/ecpg/ecpglib/descriptor.c | 3 ++-
src/interfaces/ecpg/ecpglib/execute.c | 2 +-
src/interfaces/ecpg/ecpglib/pg_type.h | 18 ------------------
src/interfaces/ecpg/ecpglib/sqlda.c | 3 ++-
src/interfaces/ecpg/ecpglib/typename.c | 3 ++-
src/test/modules/test_rls_hooks/test_rls_hooks.c | 20 ++++++++++----------
src/tools/findoidjoins/findoidjoins.c | 2 +-
27 files changed, 51 insertions(+), 67 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2018-04-08 18:14:29 Re: pgsql: Replace our traditional initial-catalog-data format with a bette
Previous Message Tom Lane 2018-04-08 17:17:44 pgsql: Replace our traditional initial-catalog-data format with a bette