pgsql: Support new default roles with adminpack

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Support new default roles with adminpack
Date: 2018-04-06 18:47:38
Message-ID: E1f4WOg-0007jJ-H5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Support new default roles with adminpack

This provides a newer version of adminpack which works with the newly
added default roles to support GRANT'ing to non-superusers access to
read and write files, along with related functions (unlinking files,
getting file length, renaming/removing files, scanning the log file
directory) which are supported through adminpack.

Note that new versions of the functions are required because an
environment might have an updated version of the library but still have
the old adminpack 1.0 catalog definitions (where EXECUTE is GRANT'd to
PUBLIC for the functions).

This patch also removes the long-deprecated alternative names for
functions that adminpack used to include and which are now included in
the backend, in adminpack v1.1. Applications using the deprecated names
should be updated to use the backend functions instead. Existing
installations which continue to use adminpack v1.0 should continue to
function until/unless adminpack is upgraded.

Reviewed-By: Michael Paquier
Discussion: https://postgr.es/m/20171231191939.GR2416%40tamriel.snowman.net

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/11523e860f8fe29f9142fb63c44e01cd0d5e7375

Modified Files
--------------
contrib/adminpack/Makefile | 2 +-
contrib/adminpack/adminpack--1.0--1.1.sql | 51 +++++++
contrib/adminpack/adminpack.c | 245 +++++++++++++++++++++++++++---
contrib/adminpack/adminpack.control | 2 +-
contrib/adminpack/expected/adminpack.out | 19 ++-
contrib/adminpack/sql/adminpack.sql | 14 +-
doc/src/sgml/adminpack.sgml | 55 +------
src/backend/utils/adt/genfile.c | 53 ++++++-
src/backend/utils/adt/misc.c | 27 +++-
src/include/catalog/pg_proc.h | 8 +-
10 files changed, 388 insertions(+), 88 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-04-06 19:52:03 pgsql: Faster partition pruning
Previous Message Robert Haas 2018-04-06 18:35:42 Re: pgsql: New files for MERGE