pgsql: Use ARMv8 CRC instructions where available.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use ARMv8 CRC instructions where available.
Date: 2018-04-04 09:23:16
Message-ID: E1f3edQ-0004tJ-26@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use ARMv8 CRC instructions where available.

ARMv8 introduced special CPU instructions for calculating CRC-32C. Use
them, when available, for speed.

Like with the similar Intel CRC instructions, several factors affect
whether the instructions can be used. The compiler intrinsics for them must
be supported by the compiler, and the instructions must be supported by the
target architecture. If the compilation target architecture does not
support the instructions, but adding "-march=armv8-a+crc" makes them
available, then we compile the code with a runtime check to determine if
the host we're running on supports them or not.

For the runtime check, use glibc getauxval() function. Unfortunately,
that's not very portable, but I couldn't find any more portable way to do
it. If getauxval() is not available, the CRC instructions will still be
used if the target architecture supports them without any additional
compiler flags, but the runtime check will not be available.

Original patch by Yuqi Gu, heavily modified by me. Reviewed by Andres
Freund, Thomas Munro.

Discussion: https://www.postgresql.org/message-id/HE1PR0801MB1323D171938EABC04FFE7FA9E3110%40HE1PR0801MB1323.eurprd08.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f044d71e331d77a0039cec0a11859b5a3c72bc95

Modified Files
--------------
config/c-compiler.m4 | 34 ++++
configure | 194 +++++++++++++++++++--
configure.in | 87 +++++++--
src/Makefile.global.in | 1 +
src/include/pg_config.h.in | 9 +
src/include/port/pg_crc32c.h | 26 ++-
src/port/Makefile | 4 +
src/port/pg_crc32c_armv8.c | 72 ++++++++
src/port/pg_crc32c_armv8_choose.c | 55 ++++++
...pg_crc32c_choose.c => pg_crc32c_sse42_choose.c} | 13 +-
src/tools/msvc/Mkvcbuild.pm | 2 +-
11 files changed, 456 insertions(+), 41 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2018-04-04 09:38:20 pgsql: Fix pg_bsaebackup checksum tests
Previous Message Heikki Linnakangas 2018-04-04 08:35:18 pgsql: Also fix the descriptions in pg_config.h.win32.